A possible fix for issue #5 regarding basic_cancel timing#6
Open
rrehbein wants to merge 11 commits intotnc:masterfrom
Open
A possible fix for issue #5 regarding basic_cancel timing#6rrehbein wants to merge 11 commits intotnc:masterfrom
rrehbein wants to merge 11 commits intotnc:masterfrom
Conversation
… issues. A possible alternative is to reject the messages so they can be re-delivered
…ges during wait for basic_cancel_ok message. Added options to allow special handling during cancelling. Added an option for special handling of unexpected basic_deliver messages
… still wait for the actual cancel
Conflicts: amqp.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustments for resolving issue #5 AMQPChannel::basic_cancel should have a defined or definable behavior about timing issues.